Summary

Fixes the remaining thread-unsafe global mutable state in praisonaiagents.main that was identified in issue #1158.

While most thread safety issues were resolved in previous PRs (#1175, #1177, #1191, #1193, #1206), the global state in main.py still lacked proper synchronization protection.

Issues Fixed

Thread-Unsafe Globals in main.py:

• error_logs = [] - Unprotected list appends causing race conditions
• sync_display_callbacks = {} - Unprotected dict mutations
• async_display_callbacks = {} - Unprotected dict mutations
• approval_callback = None - Unprotected variable assignment

Implementation Details

Thread-Safe Protection

• Added _main_globals_lock = threading.Lock() to protect all global state mutations
• Created thread-safe accessor functions for all global mutations
• Updated internal functions to use thread-safe accessors

Backward Compatibility

• All existing public APIs remain unchanged
• Internal functions updated to use thread-safe accessors
• Direct global references maintained for read access

Testing

Comprehensive Thread Safety Tests:

• 20 concurrent workers registering callbacks simultaneously
• 15 threads each logging 10 errors (150 total operations)
• Zero race conditions or data corruption detected

Adherence to Repository Guidelines

• Follows Multi-agent + async safe by default principle from AGENTS.md
• Uses efficient locking with minimal performance overhead
• Maintains existing patterns established in the codebase
• Zero breaking changes to public APIs

Generated with Claude Code